Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expose boltsCount and pitches in GraphQL mutation SingleClimbChangeInput #365

Merged
merged 4 commits into from
Jan 10, 2024

Conversation

l4u532
Copy link
Contributor

@l4u532 l4u532 commented Dec 9, 2023

The Mutation SingleClimbChangeInput is actually missing the fields boltsCount and pitches. Hence, these cannot be safely updated using the GraphQL Mutation. This should finalise #350.

What’s changed:

  • exposed boltsCount and pitches in Mutation SingleClimbChangeInput
  • renamed Pitch.grades to Pitch.grade and harmonised behaviour of Climb.grade with Pitch.grade
  • made pitches’ parentId optional, since individual pitches cannot be updated anyway without providing a parent climb’s uuid (== a pitch’s parentId); also, this was preventing comfortably adding a climb + its pitches in one, single Mutation
  • added a UserInput check to verify that each pitchNumber is unique for a given Mutation

…f disciplines/type variable between Climb and Pitches

expose boltsCount and pitches in GraphQL mutation, harmonise naming of disciplines variable
@l4u532 l4u532 force-pushed the fix/expose-hidden-db-fields branch from 8dacaeb to daa8513 Compare December 9, 2023 19:20
@l4u532 l4u532 marked this pull request as ready for review January 9, 2024 20:10
@l4u532 l4u532 changed the title WIP: fix: expose boltsCount and pitches in GraphQL mutation SingleClimbChangeInput fix: expose boltsCount and pitches in GraphQL mutation SingleClimbChangeInput Jan 10, 2024
input DisciplineType {
"https://en.wikipedia.org/wiki/Traditional_climbing"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed these comments to clean up code

@vnugent vnugent merged commit d649c6d into OpenBeta:develop Jan 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants